[strongSwan-dev] imv_attestation crash

[Andreas Steffen]

Hmmm, why not always return

  this->workitems->create_enumerator(this->workitems);

which is always defined over the lifetime of the session object
and is initially an empty list before the policy is fetched.

The policy_started check returning NULL seems like some legacy stuff
which was needed in an earlier version but which has been obsoleted.
I'm going to check how the current mechanism works.

Andreas

On 06/18/2014 12:57 PM, Martin Willi wrote:
> Avesh,
> 
>> 	if (!this->policy_started)
>> 	{
>> 		return enumerator_create_empty();
>> 	}
>>
>> I see that the enumerator is always well defined so that there must
>> be another reason for the crash.
> 
> That method returned NULL in 5.1.3, which could result in the mentioned
> crash. I've fixed the issue a while ago with the commit at [1].
> 
> Regards
> Martin
> 
> [1]http://git.strongswan.org/?p=strongswan.git;a=commitdiff;h=ede10dd9

======================================================================
Andreas Steffen                         andreas.steffen at strongswan.org
strongSwan - the Open Source VPN Solution!          www.strongswan.org
Institute for Internet Technologies and Applications
University of Applied Sciences Rapperswil
CH-8640 Rapperswil (Switzerland)
===========================================================[ITA-HSR]==

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4255 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.strongswan.org/pipermail/dev/attachments/20140618/859c09ce/attachment.bin>