[strongSwan-dev] [PATCH] vici: add support for SA updown notifications

Martin Willi martin at strongswan.org
Wed Aug 27 09:59:28 CEST 2014

Hi Timo,

Thanks for your patch.

> First attempt, for feedback. This allows vici clients to subscribe
> ike-updown and child-updown events for tracking active SAs.

Overall that looks fine. Some minor comments:

> +	this->dispatcher->raise_event(this->dispatcher, "ike-updown", 0, b->finalize(b));

> +	this->dispatcher->raise_event(this->dispatcher, "child-updown", 0, b->finalize(b));

We prefer to limit line with to about 80 chars.
> +				return command_usage("invalid --list-sas option");

That's --monitor-sas for this command.

> +		monitor_sas, 'm', "monitor-sa", "monitor for IKE_SA changes",

That would be IKE_SA and CHILD_SA changes, right?

If possible please split up vici and swanctl patches, as the vici
changes are actually independent. As your changes are not trivial, we
need them under the MIT license (see [1]), please add an appropriate
license header with your copyright.

Kind regards


More information about the Dev mailing list