[strongSwan-dev] [PATCH] Destroy active task list before queued tasks

Thomas Egerer thomas.egerer at secunet.com
Mon Jan 16 17:41:47 CET 2012


Since active task's destruction might result in adopting tasks from a
rekeyed ike sa it seems better to first destroy the active task list and
then destroy all queued tasks. This way adoption is possible at all,
while otherwise the queued task list would be empty.
---
 src/libcharon/sa/task_manager.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Hello *,

searching for a bug we noticed that during destruction of the task_manager
certain tasks in the queue might get lost when queued tasks list is destroyed
before active tasks list is.
I was wondering if there is a particular reason for this behavior? If not
please consider the patch attached for inclusion into the upstream strongswan.

Cheers

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Destroy-active-task-list-before-queued-tasks.patch
Type: text/x-patch
Size: 874 bytes
Desc: not available
URL: <http://lists.strongswan.org/pipermail/dev/attachments/20120116/3d0efa98/attachment.bin>


More information about the Dev mailing list