[strongSwan-dev] [Patch] support dynamic IP adresses

Martin Willi martin at strongswan.org
Thu Sep 1 10:45:12 CEST 2011


> You dropped the /* KW_HOST */ comment - intention or accident?

Intention, all the config members that match to a KW_ keyword don't have
that comment.

> DNS names can be given with or without a '%' prefix, and I would expect
> > +				end->host = clone_str(value);
> to be executed in either case. The (!end->allow_any) conditional looks
> superfluous to me.

Yes, didn't think about this format, I'll fix that.


More information about the Dev mailing list