[strongSwan-dev] [Patch] support dynamic IP adresses

[Martin Willi]

Hi Mirko,

I finally had a chance to look at your patch, sorry that it took that
long.

> Please comment, and consider for inclusion in strongSwan.

The patch looks fine, might be a little more complicated than required,
though:

> +               char            *dnsname;
> +               bool            has_dnsname;

Using "host" as member is probably easier, as it refers to the KW_HOST
keyword. The has_dnsname attribute could be eliminated by just setting
dnsname/host to NULL(?).

> -       plog("# bad addr: %s=%s [%s]", name, value, ugh);
> -       if (streq(ugh, "does not look numeric and name lookup failed"))
> -       {
> -               end->dns_failed = TRUE;

I think it would be a good idea to accept name resolution failures and
just pass on the DNS name to charon. This would allow us to use the
connection even if the name is not resolvable during startup.

I've attached a patch containing these modifications. I'll push it if it
looks fine to you.

Regards
Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-starter-passes-unresolved-DNS-names-to-charon.patch
Type: text/x-patch
Size: 7239 bytes
Desc: not available
URL: <http://lists.strongswan.org/pipermail/dev/attachments/20110829/f651a905/attachment.bin>