[strongSwan-dev] [PATCH 1/1] Correct check of traffic selectors before destruction

Thomas Egerer hakke_007 at gmx.de
Mon Jun 28 22:18:25 CEST 2010


Hello Martin, *,

if the attached patch is wrong I need an explanation.

Cheers,

Thomas

---
 src/libcharon/sa/tasks/child_create.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libcharon/sa/tasks/child_create.c
b/src/libcharon/sa/tasks/child_create.c
index bea4f73..ed468ec 100644
--- a/src/libcharon/sa/tasks/child_create.c
+++ b/src/libcharon/sa/tasks/child_create.c
@@ -1229,11 +1229,11 @@ static void migrate(private_child_create_t
*this, ike_sa_t *ike_sa)
 {
 	chunk_free(&this->my_nonce);
 	chunk_free(&this->other_nonce);
-	if (this->tsi)
+	if (this->tsr)
 	{
 		this->tsr->destroy_offset(this->tsr, offsetof(traffic_selector_t,
destroy));
 	}
-	if (this->tsr)
+	if (this->tsi)
 	{
 		this->tsi->destroy_offset(this->tsi, offsetof(traffic_selector_t,
destroy));
 	}
-- 
1.7.1






More information about the Dev mailing list