[strongSwan-dev] [PATCH 0/5] Recover IKE_SA reset after successful IKE_SA_INIT

Martin Willi martin at strongswan.org
Mon Jun 7 15:28:39 CEST 2010

Hi Thomas,

> * the helpful debug output for a),

Applied, [1].

> * an additional printf_hook addressing b),

I'm a little sceptic about introducing printf_hooks for such less
generic objects. The hook works fine for logging to console, but does
not help much if you want to display it to other mediums (web interface,
GUI, whatever). So I'd prefer some getters for queued tasks, and do the
formatting in the stroke plugin itself. I pushed some patches to provide
such an API [2], [3] ...

> * some optimization for the use of the newly introduced hook in
>   stroke_list,
> * the actual use of the hook in stroke_list, and last but not least

... and print it in stroke [4].

> * my proposal for a solution of the problem mentioned above

Your approach looks fine to me. I'd prefer to keep the task creation
outside of the task_manager [5], but this is purely a matter of taste.

The ike_sa_t.reset() function was not really complete for this
post-ike_init case, patch [6] resets some additional state. [7] is
required to properly make use of this state.

Many thanks for your valuable patches, Thomas!

Best regards


More information about the Dev mailing list