[strongSwan-dev] [PATCH] DiffieHellman Groups 22-24 in RFC5114

Martin Willi martin at strongswan.org
Mon Apr 19 14:50:36 CEST 2010


Hi Joy,

> +       lib->crypto->add_dh(lib->crypto, MODP_1024_160,
> +       lib->crypto->add_dh(lib->crypto, MODP_2048_224,
> +       lib->crypto->add_dh(lib->crypto, MODP_2048_256,
>         lib->crypto->add_dh(lib->crypto, MODP_2048_BIT,
>         lib->crypto->add_dh(lib->crypto, MODP_1536_BIT, 

I slightly changed the group registration order, as the first registered
group is used by default. MODP_1024_160 probably not the ideal candidate
for the default group.

Otherwise the patch looks fine, applied to master. I additionally
registered the new groups in the gcrypt and openssl plugins.

Many thanks to your contribution.

Best regards
Martin





More information about the Dev mailing list