<div dir="ltr">I'll give it a shot at latest Monday. Thanks!<div><br></div><div style>--<br>Paul</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 7, 2013 at 1:02 AM, Martin Willi <span dir="ltr"><<a href="mailto:martin@strongswan.org" target="_blank">martin@strongswan.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Paul,<br>
<br>
> [...] which I tracked down to the tsi of the Cisco peer not returning a<br>
<div class="im">> port number in its reply.<br>
<br>
</div>I see.<br>
<div class="im"><br>
> Using the patch below, I was able to accommodate this omission. Does<br>
> this seem like a reasonable change, perhaps behind a configuration<br>
> flag?<br>
<br>
</div>Thanks for the patch, looks reasonable. I don't think a configuration<br>
option is necessary, as long as we install the more restrictive<br>
selector.<br>
<br>
Instead of just checking the port, I think we can handle this in a more<br>
generic way by selecting the subset of the proposed and the returned<br>
selector. This should work in any case, in is actually even simpler.<br>
Please try the attached patch, if that works, I can push it to master.<br>
<br>
Best regards<br>
<span class="HOEnZb"><font color="#888888">Martin<br>
</font></span></blockquote></div><br></div>